Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22227#discussion_r216941747
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3404,19 +3404,27 @@ setMethod("collect_set",
     #' Equivalent to \code{split} SQL function.
     #'
     #' @rdname column_string_functions
    +#' @param limit determines the length of the returned array.
    +#'          \itemize{
    +#'          \item \code{limit > 0}: length of the array will be at most 
\code{limit}
    +#'          \item \code{limit <= 0}: the returned array can have any length
    +#'          }
    --- End diff --
    
    To make it consistent with the reference I gave:
    
    ```
    #' @param limit determines the length of the returned array.
    #'              \itemize{
    #'              \item \code{limit > 0}: length of the array will be at most 
\code{limit}
    #'              \item \code{limit <= 0}: the returned array can have any 
length
    #'              }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to