Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22227#discussion_r217953294 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1803,6 +1803,18 @@ test_that("string operators", { collect(select(df4, split_string(df4$a, "\\\\")))[1, 1], list(list("a.b@c.d 1", "b")) ) + expect_equal( + collect(select(df4, split_string(df4$a, "\\.", 2)))[1, 1], + list(list("a", "b@c.d 1\\b")) + ) + expect_equal( + collect(select(df4, split_string(df4$a, "b", -2)))[1, 1], + list(list("a.", "@c.d 1\\", "")) + ) + expect_equal( + collect(select(df4, split_string(df4$a, "b", 0)))[1, 1], --- End diff -- for context, we've had some cases in the past the wrong value is passed for an parameter - so let's at least get one with and one without any optional parameter
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org