GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/22432

    [SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky ExternalAppendOnlyMapSuite 
due to timeout

    ## What changes were proposed in this pull request?
    
    SPARK-22713 uses `eventually` with the default timeout `150ms`. It causes 
flakiness because it's only executed once when GC is slow.
    
    ```scala
    eventually {
      System.gc()
      ...
    }
    ```
    
    **Failures**
    ```scala
    org.scalatest.exceptions.TestFailedDueToTimeoutException:
    The code passed to eventually never returned normally.
    Attempted 1 times over 501.22261 milliseconds.
    Last failure message: tmpIsNull was false.
    ```
    - 
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-2.7/4916
    - 
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-2.7/4906
    - 
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-2.7/4907
    
    ## How was this patch tested?
    
    Pass the Jenkins.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-22713

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22432
    
----
commit 04c3f7b3c2a1b6a79d571ca2079ca6cc477027a7
Author: Dongjoon Hyun <dongjoon@...>
Date:   2018-09-16T02:55:05Z

    [SPARK-22713][CORE][FOLLOWUP] Fix flaky ExternalAppendOnlyMapSuite due to 
timeout

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to