Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22432#discussion_r217902327
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala
---
@@ -457,7 +458,7 @@ class ExternalAppendOnlyMapSuite extends SparkFunSuite
//
https://github.com/scala/scala/blob/2.13.x/test/junit/scala/tools/testing/AssertUtil.scala
// (lines 69-89)
// assert(map.currentMap == null)
- eventually {
+ eventually(timeout(5 seconds), interval(200 milliseconds)) {
--- End diff --
Thank you for review, @eyalfa .
If you are looking at Spark code, you must notice that the most test cases
are designed to have their suitable timeout and interval. We don't use a long
global value for all test cases. That will hide potential big issues.
Also, I already knew that the other instance you mentioned, and 4 instance
more on `ProcessingTimeExecutorSuite`. However, I didn't want to change it
because I usually don't touch the test cases if it's not flaky.
Specifically, this instance is really serious in our Jenkins environment.
The above 7 failures are only recent samples from 2 test series. We have
additional 3 test series on branch `master`; maven-hadoop2.6, maven-hadoop2.7,
sbt-scala-2.12. For `branch-2.4`, we have 4 more.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
