Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22432#discussion_r217916510
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala
---
@@ -457,7 +458,7 @@ class ExternalAppendOnlyMapSuite extends SparkFunSuite
//
https://github.com/scala/scala/blob/2.13.x/test/junit/scala/tools/testing/AssertUtil.scala
// (lines 69-89)
// assert(map.currentMap == null)
- eventually {
+ eventually(timeout(5 seconds), interval(200 milliseconds)) {
--- End diff --
+1 for not overkilling it. If this is the only flaky test, let's fix this
instance
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
