Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22441#discussion_r218078496
  
    --- Diff: dev/create-release/release-build.sh ---
    @@ -183,8 +188,17 @@ if [[ "$1" == "package" ]]; then
       # Updated for each binary build
       make_binary_release() {
         NAME=$1
    -    FLAGS="$MVN_EXTRA_OPTS -B $SCALA_2_11_PROFILES $BASE_RELEASE_PROFILES 
$2"
    -    BUILD_PACKAGE=$3
    +    SCALA_VERSION=$2
    +    SCALA_PROFILES=
    +    if [[ SCALA_VERSION == "2.10" ]]; then
    --- End diff --
    
    I think the 2.10-related lines can be deleted as of branch 2.4 and beyond, 
as there are no 2.10 builds since 2.3. Optional.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to