Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22441#discussion_r218079177
  
    --- Diff: dev/create-release/release-build.sh ---
    @@ -112,11 +112,16 @@ fi
     # different versions of Scala are supported.
     BASE_PROFILES="-Pmesos -Pyarn"
     PUBLISH_SCALA_2_10=0
    +PUBLISH_SCALA_2_12=0
     SCALA_2_10_PROFILES="-Pscala-2.10"
     SCALA_2_11_PROFILES=
     SCALA_2_12_PROFILES="-Pscala-2.12"
     
    -if [[ $SPARK_VERSION > "2.3" ]]; then
    +if [[ $SPARK_VERSION > "2.4" ]]; then
    +  BASE_PROFILES="$BASE_PROFILES -Pkubernetes -Pflume"
    +  SCALA_2_11_PROFILES="-Pkafka-0-8"
    --- End diff --
    
    I suppose you could separate these two if conditions, to avoid repeating 
the two lines above. Optional.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to