Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22441#discussion_r218464733
--- Diff: dev/create-release/release-build.sh ---
@@ -414,15 +437,15 @@ if [[ "$1" == "publish-release" ]]; then
-DskipTests $PUBLISH_PROFILES $SCALA_2_10_PROFILES clean install
fi
- #./dev/change-scala-version.sh 2.12
- #$MVN -DzincPort=$ZINC_PORT -Dmaven.repo.local=$tmp_repo \
- # -DskipTests $SCALA_2_12_PROFILES §$PUBLISH_PROFILES clean install
+ if ! is_dry_run && [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
+ ./dev/change-scala-version.sh 2.12
+ $MVN -DzincPort=$((ZINC_PORT + 2)) -Dmaven.repo.local=$tmp_repo
-Dscala-2.12 \
+ -DskipTests $PUBLISH_PROFILES $SCALA_2_12_PROFILES clean install
+ fi
--- End diff --
We tried to do it before but it's commented out:
https://github.com/apache/spark/pull/22441/files#diff-01ca42240614718522afde4d4885b40dL424
I didn't look into it and seems it's OK as the release script is able to do
scala 2.10 build.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
