Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22441#discussion_r218471225
--- Diff: dev/create-release/release-build.sh ---
@@ -414,15 +437,15 @@ if [[ "$1" == "publish-release" ]]; then
-DskipTests $PUBLISH_PROFILES $SCALA_2_10_PROFILES clean install
fi
- #./dev/change-scala-version.sh 2.12
- #$MVN -DzincPort=$ZINC_PORT -Dmaven.repo.local=$tmp_repo \
- # -DskipTests $SCALA_2_12_PROFILES §$PUBLISH_PROFILES clean install
+ if ! is_dry_run && [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
+ ./dev/change-scala-version.sh 2.12
+ $MVN -DzincPort=$((ZINC_PORT + 2)) -Dmaven.repo.local=$tmp_repo
-Dscala-2.12 \
+ -DskipTests $PUBLISH_PROFILES $SCALA_2_12_PROFILES clean install
+ fi
--- End diff --
I believe I added it, commented out, for the time when we enabled a 2.12
build. My concern is just that it leaves the checkout in a state that builds
for 2.12. If you tried a 2.11 build afterwards it would fail. But I suppose it
would clearly fail. I suppose it will work here as it's the last thing this
tries to do, so the end state doesn't matter. Tidy, but optional to set it back.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
