Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22533#discussion_r220218715
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -54,6 +54,22 @@ def _to_java_column(col):
         return jcol
     
     
    +def _to_sorted_java_columns(cols, ascending=True):
    +    if len(cols) == 1 and isinstance(cols[0], list):
    +        cols = cols[0]
    +    jcols = [_to_java_column(c) for c in cols]
    +    if isinstance(ascending, (bool, int)):
    +        if not ascending:
    +            jcols = [jc.desc() for jc in jcols]
    +    elif isinstance(ascending, list):
    +        jcols = [jc if asc else jc.desc()
    +                 for asc, jc in zip(ascending, jcols)]
    --- End diff --
    
    Btw this can be easily worked around. I think we don't need to add this 
argument


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to