Github user rezasafi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22612#discussion_r222528022
  
    --- Diff: 
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
    @@ -84,6 +122,8 @@ case object MappedPoolMemory extends 
MBeanExecutorMetricType(
       "java.nio:type=BufferPool,name=mapped")
     
     private[spark] object ExecutorMetricType {
    +  final val pTreeInfo = new ProcfsBasedSystems
    --- End diff --
    
    I first considered this class to have a companion object, but it didn't 
work. Mostly related to how the ExecutorMetricType is defined. I don't remember 
the exact detail. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to