Github user dhruve commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r222785629
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -59,6 +60,43 @@ case object JVMOffHeapMemory extends ExecutorMetricType {
}
}
+case object ProcessTreeJVMRSSMemory extends ExecutorMetricType {
+ override private[spark] def getMetricValue(memoryManager:
MemoryManager): Long = {
+ ExecutorMetricType.pTreeInfo.updateAllMetrics()
--- End diff --
Should make ProcessTreeMemory extends ExecutorMetricType and individual
metrics can be returned from it. This also makes the assumption of calculating
the metrics only in the ProcessTreeJVMRSSMemory and subsequent calls using it.
We shouldn't depend on the order here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
