Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22652#discussion_r223195385 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/HashByteArrayBenchmark.scala --- @@ -19,15 +19,23 @@ package org.apache.spark.sql import java.util.Random -import org.apache.spark.benchmark.Benchmark +import org.apache.spark.benchmark.{Benchmark, BenchmarkBase} import org.apache.spark.sql.catalyst.expressions.{HiveHasher, XXH64} import org.apache.spark.unsafe.Platform import org.apache.spark.unsafe.hash.Murmur3_x86_32 /** * Synthetic benchmark for MurMurHash 3 and xxHash64. + * To run this benchmark: + * {{{ + * 1. without sbt: bin/spark-submit --class <this class> <spark catalyst test jar> --- End diff -- Is this correct guide? `BenchmarkBase` is in a different jar file, isn't it?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org