Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22652#discussion_r223202487
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/HashByteArrayBenchmark.scala
---
@@ -19,15 +19,23 @@ package org.apache.spark.sql
import java.util.Random
-import org.apache.spark.benchmark.Benchmark
+import org.apache.spark.benchmark.{Benchmark, BenchmarkBase}
import org.apache.spark.sql.catalyst.expressions.{HiveHasher, XXH64}
import org.apache.spark.unsafe.Platform
import org.apache.spark.unsafe.hash.Murmur3_x86_32
/**
* Synthetic benchmark for MurMurHash 3 and xxHash64.
+ * To run this benchmark:
+ * {{{
+ * 1. without sbt: bin/spark-submit --class <this class> <spark catalyst
test jar>
--- End diff --
Yes, you are right:
```
LM-SHC-16502798:spark yumwang$ bin/spark-submit --class
org.apache.spark.sql.HashByteArrayBenchmark
./sql/catalyst/target/spark-catalyst_2.11-3.0.0-SNAPSHOT-tests.jar18/10/07
07:35:09 WARN NativeCodeLoader: Unable to load native-hadoop library for your
platform... using builtin-java classes where applicable
Exception in thread "main" java.lang.NoClassDefFoundError:
org/apache/spark/benchmark/BenchmarkBase
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
......
```
The correct usage should be:
```
bin/spark-submit --class org.apache.spark.sql.HashByteArrayBenchmark
--jars ./core/target/spark-core_2.11-3.0.0-SNAPSHOT-tests.jar
./sql/catalyst/target/spark-catalyst_2.11-3.0.0-SNAPSHOT-tests.jar
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
