Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r223436057 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -433,4 +465,36 @@ class ClientSuite extends SparkFunSuite with Matchers { classpath(env) } + private def testResourceRequest(expectedResources: Seq[(String, Long)], --- End diff -- This is weird. The expected resources are a parameter, but the config is hardcoded in this test method. That is kinda brittle. Instead, use the `deployMode` parameter to define the expected resources.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org