Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223442688
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
---
@@ -87,6 +88,20 @@ class YarnAllocatorSuite extends SparkFunSuite with
Matchers with BeforeAndAfter
def createAllocator(
maxExecutors: Int = 5,
rmClient: AMRMClient[ContainerRequest] = rmClient): YarnAllocator = {
+ createAllocatorInternal(maxExecutors, rmClient, Map())
+ }
+
+ def createAllocatorWithAdditionalConfigs(
--- End diff --
You can just add a new parameter with a default value to the existing
method and avoid this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
