Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22639#discussion_r223518123
  
    --- Diff: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/StreamingCompatibilitySuite.scala
 ---
    @@ -0,0 +1,220 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.k8s.integrationtest
    +
    +import java.net._
    +
    +import scala.collection.JavaConverters._
    +import scala.concurrent.ExecutionContext.Implicits.global
    +import scala.concurrent.Future
    +
    +import io.fabric8.kubernetes.api.model.Service
    +import org.scalatest.concurrent.{Eventually, PatienceConfiguration}
    +import org.scalatest.time.{Minutes, Span}
    +
    +import org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite._
    +import org.apache.spark.util
    +
    +private[spark] trait StreamingCompatibilitySuite {
    +
    +  k8sSuite: KubernetesSuite =>
    +
    +  private def startSocketServer(): (String, Int, ServerSocket) = {
    --- End diff --
    
    Is this the submission client starting a server, and then the pod needs to 
be able to connect to the submission client host and port? An alternative is to 
deploy a separate pod that does this so that network communications are 
pod-to-pod instead of pod-to-host.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to