Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22639#discussion_r223519103 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/StreamingCompatibilitySuite.scala --- @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.deploy.k8s.integrationtest + +import java.net._ + +import scala.collection.JavaConverters._ +import scala.concurrent.ExecutionContext.Implicits.global +import scala.concurrent.Future + +import io.fabric8.kubernetes.api.model.Service +import org.scalatest.concurrent.{Eventually, PatienceConfiguration} +import org.scalatest.time.{Minutes, Span} + +import org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite._ +import org.apache.spark.util + +private[spark] trait StreamingCompatibilitySuite { + + k8sSuite: KubernetesSuite => + + private def startSocketServer(): (String, Int, ServerSocket) = { + val hostname = util.Utils.localHostName() + val hostAddress: String = InetAddress.getByName(hostname).getHostAddress + val serverSocket = new ServerSocket() + serverSocket.bind(new InetSocketAddress(hostAddress, 0)) + val host = serverSocket.getInetAddress.getHostAddress + val port = serverSocket.getLocalPort + logInfo(s"Started test server socket at $host:$port") + Future { + while (!serverSocket.isClosed) { + val socket: Socket = serverSocket.accept() + logInfo(s"Received connection on $socket") + for (i <- 1 to 10 ) { + if (socket.isConnected && !serverSocket.isClosed) { + socket.getOutputStream.write("spark-streaming-kube test.\n".getBytes()) + socket.getOutputStream.flush() + Thread.sleep(100) + } + } + socket.close() + } + } + (host, port, serverSocket) + } + + test("Run spark streaming in client mode.", k8sTestTag) { + val (host, port, serverSocket) = startSocketServer() + val (driverPort: Int, blockManagerPort: Int, driverService: Service) = + driverServiceSetup(driverPodName) + try { + val driverPod = setupSparkStreamingPod("client", driverPodName) + .addToArgs("--conf", s"spark.driver.host=" + + s"${driverService.getMetadata.getName}.${kubernetesTestComponents.namespace}.svc") + .addToArgs("--conf", s"spark.driver.port=$driverPort") + .addToArgs("--conf", s"spark.driver.blockManager.port=$blockManagerPort") + .addToArgs("streaming.NetworkWordCount") + .addToArgs(host, port.toString) + .endContainer() + .endSpec() + .done() + + Eventually.eventually(TIMEOUT, INTERVAL) { + assert(getRunLog(driverPodName) + .contains("spark-streaming-kube"), "The application did not complete.") + } + } finally { + // Have to delete the service manually since it doesn't have an owner reference + kubernetesTestComponents + .kubernetesClient + .services() + .inNamespace(kubernetesTestComponents.namespace) + .delete(driverService) + serverSocket.close() + } + } + + test("Run spark streaming in cluster mode.", k8sTestTag) { + val (host, port, serverSocket) = startSocketServer() + try { + runSparkJVMCheckAndVerifyCompletion( + mainClass = "org.apache.spark.examples.streaming.NetworkWordCount", + appArgs = Array[String](host, port.toString), + expectedJVMValue = Seq("spark-streaming-kube")) + } finally { + serverSocket.close() + } + } + + test("Run spark structured streaming in cluster mode.", k8sTestTag) { + val (host, port, serverSocket) = startSocketServer() + try { + runSparkJVMCheckAndVerifyCompletion( + mainClass = "org.apache.spark.examples.sql.streaming.StructuredNetworkWordCount", + appArgs = Array[String](host, port.toString), + expectedJVMValue = Seq("spark-streaming-kube")) + } finally { + serverSocket.close() + } + } + + test("Run spark structured streaming in client mode.", k8sTestTag) { + val (host, port, serverSocket) = startSocketServer() + val (driverPort: Int, blockManagerPort: Int, driverService: Service) = + driverServiceSetup(driverPodName) + try { + val driverPod = setupSparkStreamingPod("client", driverPodName) + .addToArgs("--conf", + s"spark.driver.host=" + + s"${driverService.getMetadata.getName}.${kubernetesTestComponents.namespace}.svc") + .addToArgs("--conf", s"spark.driver.port=$driverPort") + .addToArgs("--conf", s"spark.driver.blockManager.port=$blockManagerPort") + .addToArgs("sql.streaming.StructuredNetworkWordCount") + .addToArgs(host, port.toString) + .endContainer() + .endSpec() + .done() + + val TIMEOUT = PatienceConfiguration.Timeout(Span(3, Minutes)) + Eventually.eventually(TIMEOUT, INTERVAL) { + assert(getRunLog(driverPodName).contains("spark-streaming-kube"), + "The application did not complete.") + } + } + finally { + // Have to delete the service manually since it doesn't have an owner reference + kubernetesTestComponents + .kubernetesClient + .services() + .inNamespace(kubernetesTestComponents.namespace) + .delete(driverService) + serverSocket.close() + } + } + + private def getRunLog(_driverPodName: String): String = kubernetesTestComponents.kubernetesClient --- End diff -- Why the underscore in `_driverPodName`? If it's a name conflict, I would presume the driver pod name is available elsewhere already and we can just use the local var and not have an argument.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org