Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223866624
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -48,6 +48,19 @@ package object config {
.bytesConf(ByteUnit.MiB)
.createOptional
+ private[spark] val DRIVER_LOG_DFS_DIR =
+ ConfigBuilder("spark.driver.log.dfsDir").stringConf.createOptional
+
+ private[spark] val DRIVER_LOG_LAYOUT =
+ ConfigBuilder("spark.driver.log.layout")
+ .stringConf
+ .createWithDefault("%d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{1}: %m%n")
+
+ private[spark] val DRIVER_LOG_SYNCTODFS =
--- End diff --
Let's leave it. But there's some usage of the enabled flag in your code
that you can still clean up.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
