Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22504#discussion_r225311218
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -281,6 +288,16 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
             pool.scheduleWithFixedDelay(
               getRunner(() => cleanLogs()), 0, CLEAN_INTERVAL_S, 
TimeUnit.SECONDS)
           }
    +
    +      driverLogFs.foreach { _ =>
    +        if (conf.get(DRIVER_LOG_CLEANER_ENABLED).getOrElse(
    +            conf.getBoolean("spark.history.fs.cleaner.enabled", false))) {
    +          pool.scheduleWithFixedDelay(getRunner(() => cleanDriverLogs()),
    +            0,
    +            
conf.get(DRIVER_LOG_CLEANER_INTERVAL).getOrElse(CLEAN_INTERVAL_S),
    --- End diff --
    
    Create config constant for existing config, use `fallbackConf`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to