Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22731#discussion_r225262559
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
@@ -106,15 +106,16 @@ class FileScanRDD(
// don't need to run this `if` for every record.
val preNumRecordsRead = inputMetrics.recordsRead
if (nextElement.isInstanceOf[ColumnarBatch]) {
+ incTaskInputMetricsBytesRead()
--- End diff --
I see, so always update when processing `ColumnarBatch`, but use the
previous logic otherwise. That seems OK. It should still address the original
problem.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
