Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22731#discussion_r225325506
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
@@ -106,15 +106,16 @@ class FileScanRDD(
// don't need to run this `if` for every record.
val preNumRecordsRead = inputMetrics.recordsRead
if (nextElement.isInstanceOf[ColumnarBatch]) {
+ incTaskInputMetricsBytesRead()
--- End diff --
... I guess the only possible drawback is that if the number of records in
a ColumnarBatch is pretty small, then this could cause it to update bytes read
a lot more frequently than before. Bu if the number of records is large (>100)
then this won't matter.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
