Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22732#discussion_r225619242
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
 ---
    @@ -31,6 +31,7 @@ import org.apache.spark.sql.types.DataType
      *                  null. Use boxed type or [[Option]] if you wanna do the 
null-handling yourself.
      * @param dataType  Return type of function.
      * @param children  The input expressions of this UDF.
    + * @param handleNullForInputs Whether the inputs need null-value handling 
respectively.
    --- End diff --
    
    Makes sense. Since I'm also using this flag to replace `KnownNotNull`, I 
think `inputsNullSafe` would be a better name?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to