Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225654592
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction protected[sql] (
f,
dataType,
exprs.map(_.expr),
+ nullableTypes.map(_.map(!_)).getOrElse(exprs.map(_ => false)),
--- End diff --
We need to be more conservative here. The default behavior needs to handle
NULLs. We should fix it.
```
// Need to handle NULL when the fields can't accept NULL.
val handleNullForInputs =
nullableTypes.map(_.map(!_)).getOrElse(Seq.fill(exprs.size)(true))
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
