Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r227526473 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala --- @@ -30,14 +30,16 @@ private[spark] trait IntegrationTestBackend { private[spark] object IntegrationTestBackendFactory { val deployModeConfigKey = "spark.kubernetes.test.deployMode" + val backendMinikube = "minikube" + val backendDockerForDesktop = "docker-for-desktop" + def getTestBackend: IntegrationTestBackend = { val deployMode = Option(System.getProperty(deployModeConfigKey)) - .getOrElse("minikube") - if (deployMode == "minikube") { - MinikubeTestBackend - } else { - throw new IllegalArgumentException( - "Invalid " + deployModeConfigKey + ": " + deployMode) + .getOrElse(backendMinikube) + deployMode match { + case `backendMinikube` => MinikubeTestBackend + case `backendDockerForDesktop` => DockerForDesktopBackend + case _ => throw new IllegalArgumentException("Invalid " + deployModeConfigKey + ": " + deployMode) --- End diff -- NIT: line too long, split
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org