Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r228258489
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala
---
@@ -28,16 +30,16 @@ private[spark] trait IntegrationTestBackend {
}
private[spark] object IntegrationTestBackendFactory {
- val deployModeConfigKey = "spark.kubernetes.test.deployMode"
-
def getTestBackend: IntegrationTestBackend = {
- val deployMode = Option(System.getProperty(deployModeConfigKey))
- .getOrElse("minikube")
- if (deployMode == "minikube") {
- MinikubeTestBackend
- } else {
- throw new IllegalArgumentException(
- "Invalid " + deployModeConfigKey + ": " + deployMode)
+ val deployMode = Option(System.getProperty(CONFIG_KEY_DEPLOY_MODE))
+ .getOrElse(BACKEND_MINIKUBE)
+ deployMode match {
+ case BACKEND_MINIKUBE => MinikubeTestBackend
+ case BACKEND_CLOUD => new KubeConfigBackend(null)
--- End diff --
Can we combine `KubeConfigBackend` and `CloudTestBackend` into one? The
only difference is how the kubeconfig gets constructed. I guess you can decide
which way to go based on the presence of the `CONFIG_KEY_KUBE_MASTER_URL`
property.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
