Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r228713022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -128,6 +128,16 @@ object ScalaReflection extends ScalaReflection {
case _ => false
}
+ def isValueClass(tpe: `Type`): Boolean = {
+ tpe.typeSymbol.asClass.isDerivedValueClass
+ }
+
+ /** Returns the underlying type of value class `cls`. */
+ def getUnderlyingTypeOf(cls: `Type`): `Type` = {
--- End diff --
agree, it's better to use `tpe`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
