Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r228713038
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -622,6 +654,14 @@ object ScalaReflection extends ScalaReflection {
dataType = ObjectType(udt.getClass))
Invoke(obj, "serialize", udt, inputObject :: Nil)
+ case t if isValueClass(t) =>
+ val (name, underlyingType) = getConstructorParameters(t).head
--- End diff --
you're right, I should return both name and type from `getUnderlyingTypeOf`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
