Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22921#discussion_r230283948
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -279,27 +254,6 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
           structDf.select(hash($"a", $"record.*")))
       }
     
    -  test("Star Expansion - explode should fail with a meaningful message if 
it takes a star") {
    --- End diff --
    
    Can we rewrite this test case using select(explode()), like what we did in 
the following test cases?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to