Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22921#discussion_r230427828
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -1641,30 +1641,30 @@ setMethod("tanh",
               })
     
     #' @details
    -#' \code{toDegrees}: Converts an angle measured in radians to an 
approximately equivalent angle
    +#' \code{degrees}: Converts an angle measured in radians to an 
approximately equivalent angle
     #' measured in degrees.
     #'
     #' @rdname column_math_functions
    -#' @aliases toDegrees toDegrees,Column-method
    -#' @note toDegrees since 1.4.0
    -setMethod("toDegrees",
    +#' @aliases degrees degrees,Column-method
    +#' @note degrees since 2.1.0
    +setMethod("degrees",
               signature(x = "Column"),
               function(x) {
    -            jc <- callJStatic("org.apache.spark.sql.functions", 
"toDegrees", x@jc)
    +            jc <- callJStatic("org.apache.spark.sql.functions", "degrees", 
x@jc)
                 column(jc)
               })
     
     #' @details
    -#' \code{toRadians}: Converts an angle measured in degrees to an 
approximately equivalent angle
    +#' \code{radians}: Converts an angle measured in degrees to an 
approximately equivalent angle
     #' measured in radians.
     #'
     #' @rdname column_math_functions
    -#' @aliases toRadians toRadians,Column-method
    -#' @note toRadians since 1.4.0
    -setMethod("toRadians",
    +#' @aliases radians radians,Column-method
    +#' @note radians since 2.1.0
    --- End diff --
    
    Similar comment with degrees


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to