Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22932#discussion_r230604337
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
    @@ -44,4 +44,13 @@ package object sql {
       type Strategy = SparkStrategy
     
       type DataFrame = Dataset[Row]
    +
    +  /**
    +   * Metadata key which is used to write Spark version in the followings:
    +   * - Parquet file metadata
    +   * - ORC file metadata
    +   *
    +   * Note that Hive table property `spark.sql.create.version` also has 
Spark version.
    +   */
    +  private[sql] val CREATE_VERSION = "org.apache.spark.sql.create.version"
    --- End diff --
    
    Is this a pre-existing key? Seems that `org.apache.spark.version` should be 
enough.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to