Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r230610261
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
@@ -44,4 +44,13 @@ package object sql {
type Strategy = SparkStrategy
type DataFrame = Dataset[Row]
+
+ /**
+ * Metadata key which is used to write Spark version in the followings:
+ * - Parquet file metadata
+ * - ORC file metadata
+ *
+ * Note that Hive table property `spark.sql.create.version` also has
Spark version.
+ */
+ private[sql] val CREATE_VERSION = "org.apache.spark.sql.create.version"
--- End diff --
Thank you for review, @hvanhovell . Yes, we can use that
`org.apache.spark.version` since this is a new key.
Although Hive table property `spark.sql.create.version` has `.create.`
part, it seems that we don't need to follow that convention here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
