Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230784165
--- Diff: R/pkg/R/generics.R ---
@@ -748,7 +748,7 @@ setGeneric("add_months", function(y, x) {
standardGeneric("add_months") })
#' @rdname column_aggregate_functions
#' @name NULL
-setGeneric("approxCountDistinct", function(x, ...) {
standardGeneric("approxCountDistinct") })
+setGeneric("approx_count_distinct", function(x, ...) {
standardGeneric("approx_count_distinct") })
--- End diff --
I think my comment didn't get connected to this one -- @felixcheung what do
you think about the argument that this almost surely was meant to be deprecated
along with counterparts in Scala/Python? leaving them in would make this
inconsistent. As the degrees, radians, and approxCountDistinct are reasonably
niche and have a direct replacement that's compatible with older versions, I
feel like this is OK for 3.0?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
