Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22975#discussion_r231978242
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/higherOrderFunctions.scala
 ---
    @@ -74,7 +76,7 @@ case class ResolveLambdaVariables(conf: SQLConf) extends 
Rule[LogicalPlan] {
       private val canonicalizer = {
         if (!conf.caseSensitiveAnalysis) {
           // scalastyle:off caselocale
    -      s: String => s.toLowerCase
    +      s: String => s.toLowerCase(Locale.ROOT)
    --- End diff --
    
    Not sure about this one. It's affecting variable names in a user's SQL? 
then it shouldn't change


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to