Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22975#discussion_r231977746
--- Diff: project/SparkBuild.scala ---
@@ -650,10 +651,13 @@ object Assembly {
},
jarName in (Test, assembly) :=
s"${moduleName.value}-test-${version.value}.jar",
mergeStrategy in assembly := {
- case m if m.toLowerCase.endsWith("manifest.mf") =>
MergeStrategy.discard
- case m if m.toLowerCase.matches("meta-inf.*\\.sf$") =>
MergeStrategy.discard
+ case m if m.toLowerCase(Locale.ROOT).endsWith("manifest.mf")
--- End diff --
I agree with these.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
