Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/22963
sorry to jump in late on this, but i just wanted to check in on some of
this stuff... `dev/lint-python` is a nightmare and i just wanted to discuss a
couple of things:
1) the script downloads pycodestyle if it's not the right version.
however, flake8, pycodestyle and sphinx are all installed and managed by the
build system (see versions @ the end of this comment). i'll update all of the
workers (and the ansible) to install the right version(s) of things as found in
the script today.
1) in addition to (1), i'd like to do one of two things: either remove the
pycodestyle download step, OR add installation steps for flake8, pydocstyle and
sphinx.
2) we currently don't have pydocstyle installed on any of the workers. i
am more than happy to install it immediately, but am concerned about build
breakages as we've never tested this before.
3) holy crap `dev/lint-python` makes my eyes bleed!
currently installed packages + versions:
```
-bash-4.1$ which pycodestyle && pycodestyle --version
/home/anaconda/bin/pycodestyle
2.3.1
-bash-4.1$ which flake8 && flake8 --version
/home/anaconda/bin/flake8
3.5.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.6.0) CPython 2.7.13
on Linux
-bash-4.1$ which sphinx-build && sphinx-build --version
/home/anaconda/envs/py3k/bin/sphinx-build
Sphinx (sphinx-build) 1.2.3
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
