Github user shaneknapp commented on the issue:

    https://github.com/apache/spark/pull/22963
  
    interesting.  from the flake8 webpage:
    ```
    It is very important to install Flake8 on the correct version of Python for 
your needs. If you want Flake8 to properly parse new language features in 
Python 3.5 (for example), you need it to be installed on 3.5 for Flake8 to 
understand those features. In many ways, Flake8 is tied to the version of 
Python on which it runs.
    ```
    
    we're testing flake8 w/python 3.4.5 on the centos workers, and soon to be 
python 3.5 everywhere.  this means that flake8 probably hasn't been behaving 
properly since the get-go.
    
    also, this PR sets the flake8 version to 3.6, which means we should be 
testing against python3.6...  i was only planning on bumping the python version 
from 3.4 -> 3.5, however.
    
    what's *also* confusing is that there are version of flake8 3.6.0 for 
python2.7, 3.6 and 3.7.
    
    i think we have some serious, and heretofore unknown, version 
incompatibilities in our python testing environment.
    
    what i'm going to do/test:
    * pin flake8 to version 3.5.0, and the python2.7 testing environment.
    * pin pycodestyle to 3.6.0, again in the python2.7 testing environment.
    * leave sphinx-build in the python 3.{4,5} environment (as it always has 
been)
    * install pydocstyle in a test env and see what breaks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to