Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22959#discussion_r234774528
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStep.scala
 ---
    @@ -28,21 +26,15 @@ import org.apache.spark.internal.Logging
      * containing Hadoop config files mounted as volumes and an ENV variable
      * pointed to the mounted file directory.
      */
    -private[spark] class HadoopConfExecutorFeatureStep(
    -    kubernetesConf: KubernetesConf[KubernetesExecutorSpecificConf])
    +private[spark] class HadoopConfExecutorFeatureStep(conf: 
KubernetesExecutorConf)
       extends KubernetesFeatureConfigStep with Logging {
     
       override def configurePod(pod: SparkPod): SparkPod = {
    -    val sparkConf = kubernetesConf.sparkConf
    -    val hadoopConfDirCMapName = sparkConf.getOption(HADOOP_CONFIG_MAP_NAME)
    +    val hadoopConfDirCMapName = 
conf.sparkConf.getOption(HADOOP_CONFIG_MAP_NAME)
    --- End diff --
    
    Looks like you can do `conf. getOption`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to