Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r234775406
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -16,40 +16,45 @@
*/
package org.apache.spark.deploy.k8s.features
-import io.fabric8.kubernetes.api.model.HasMetadata
+import io.fabric8.kubernetes.api.model.{HasMetadata, Secret, SecretBuilder}
+import org.apache.commons.codec.binary.Base64
+import org.apache.hadoop.security.{Credentials, UserGroupInformation}
import org.apache.spark.deploy.SparkHadoopUtil
-import org.apache.spark.deploy.k8s.{KubernetesConf, KubernetesUtils,
SparkPod}
+import org.apache.spark.deploy.k8s.{KubernetesDriverConf, KubernetesUtils,
SparkPod}
import org.apache.spark.deploy.k8s.Config._
import org.apache.spark.deploy.k8s.Constants._
-import org.apache.spark.deploy.k8s.KubernetesDriverSpecificConf
import org.apache.spark.deploy.k8s.features.hadooputils._
-import org.apache.spark.internal.Logging
+import org.apache.spark.deploy.security.HadoopDelegationTokenManager
/**
* Runs the necessary Hadoop-based logic based on Kerberos configs and the
presence of the
* HADOOP_CONF_DIR. This runs various bootstrap methods defined in
HadoopBootstrapUtil.
*/
-private[spark] class KerberosConfDriverFeatureStep(
- kubernetesConf: KubernetesConf[KubernetesDriverSpecificConf])
- extends KubernetesFeatureConfigStep with Logging {
+private[spark] class KerberosConfDriverFeatureStep(kubernetesConf:
KubernetesDriverConf)
+ extends KubernetesFeatureConfigStep {
- require(kubernetesConf.hadoopConfSpec.isDefined,
- "Ensure that HADOOP_CONF_DIR is defined either via env or a
pre-defined ConfigMap")
- private val hadoopConfDirSpec = kubernetesConf.hadoopConfSpec.get
private val conf = kubernetesConf.sparkConf
--- End diff --
Is `conf` still needed?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
