Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23062#discussion_r234833180
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
 ---
    @@ -462,12 +462,12 @@ case class NewInstance(
           val d = outerObj.getClass +: paramTypes
           val c = getConstructor(outerObj.getClass +: paramTypes)
           (args: Seq[AnyRef]) => {
    -        c.newInstance(outerObj +: args: _*)
    +        c(Seq(outerObj +: args: _*))
    --- End diff --
    
    Do these need to be called as varargs? it's no longer a Constructor but a 
function accepting a Seq.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to