Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234833053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -973,8 +998,19 @@ trait ScalaReflection extends Logging {
}
}
+ /**
+ * If our type is a Scala trait it may have a companion object that
+ * only defines a constructor via `apply` method.
+ */
+ def getCompanionConstructor(tpe: Type): Symbol = {
--- End diff --
Can this be private?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
