Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23126#discussion_r237130345
--- Diff: mllib/src/test/java/org/apache/spark/ml/feature/JavaPCASuite.java
---
@@ -67,7 +66,7 @@ public void testPCA() {
JavaRDD<Vector> dataRDD = jsc.parallelize(points, 2);
RowMatrix mat = new RowMatrix(dataRDD.map(
- (Vector vector) -> (org.apache.spark.mllib.linalg.Vector) new
DenseVector(vector.toArray())
+ (Vector vector) ->
org.apache.spark.mllib.linalg.Vectors.fromML(vector)
--- End diff --
I don't think that helps a caller much as they don't know what the
implication of this is. I'd leave it for now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
