Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3518#discussion_r21062370
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -788,6 +793,63 @@ class DAGScheduler(
}
}
+ /**
+ * Helper function to check whether an RDD is serializable.
+ *
+ * Note: This function is defined seperately from the
SerializationHelper.isSerializable()
+ * since DAGScheduler.isSerialiazble() is passed as a parameter to the
RDDWalker class's graph
+ * traversal, which would otherwise require knowledge of the
closureSerializer
+ * (which was undesirable).
+ *
+ * @param rdd - Rdd to attempt to serialize
+ * @return - An output string qualifying success or failure.
+ */
+ private def isSerializable(rdd: RDD[_]): String = {
+ SerializationHelper.isSerializable(closureSerializer,rdd)
--- End diff --
Put spaces between arguments: `closureSerializer, rdd` (see
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
