Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3518#discussion_r21062428
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -826,9 +888,23 @@ class DAGScheduler(
// might modify state of objects referenced in their closures. This is
necessary in Hadoop
// where the JobConf/Configuration object is not thread-safe.
var taskBinary: Broadcast[Array[Byte]] = null
+
+ // Check if RDD serialization debugging is enabled
+ // TODO After acceptance documentation for this option should be added
to ScalaDoc
+ val debugSerialization: Boolean =
sc.getConf.getOption("spark.serializer.debug")
+ .getOrElse("false").equals("true")
+
try {
- // For ShuffleMapTask, serialize and broadcast (rdd, shuffleDep).
+ // For ShuffleMapTask, serialize and broadcast (rdd, shuffleDep).
// For ResultTask, serialize and broadcast (rdd, func).
+
+ // Before serialization print out the RDD and its references.
+ if(debugSerialization)
+ {
--- End diff --
This brace should go on the same line as the `if`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
