Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3518#discussion_r21062448
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -458,6 +458,20 @@ private[spark] class TaskSetManager(
               val startTime = clock.getTime()
               // We rely on the DAGScheduler to catch non-serializable 
closures and RDDs, so in here
               // we assume the task can be serialized without exceptions.
    +
    +          // Check if serialization debugging is enabled
    +          // TODO After acceptance, documentation for this option should 
be added to ScalaDoc
    +          val printRdd : Boolean = 
sched.sc.getConf.getOption("spark.serializer.debug")
    +            .getOrElse("false").equals("true")
    +          
    +          // If enabled, print out the added JARs and files (as part of 
the context) to help 
    +          // identify unserializable components
    --- End diff --
    
    Why would added JARs / files lead to serialization errors?  I could see how 
they could create _deserialization_ errors on the workers if required classes 
were missing, but how would the presence / absence of a file or JAR prevent 
serialization?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to