Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2848#discussion_r21350437
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -412,6 +403,48 @@ private[spark] object Utils extends Logging {
}
/**
+ * Download a file from @in to @tempFile, then move it to @destFile,
checking whether @destFile
+ * already exists, is equal to the downloaded file, and can be
overwritten.
+ */
+ private def maybeMoveFile(
+ url: String,
+ sourceFile: File,
+ destFile: File,
+ fileOverwrite: Boolean): Unit = {
+
+ var shouldCopy = true
+ if (destFile.exists) {
+ if (!Files.equal(sourceFile, destFile)) {
+ if (fileOverwrite) {
+ destFile.delete()
+ logInfo(("File %s exists and does not match contents of %s, " +
+ "replacing it with %s").format(destFile, url, url))
+ } else {
+ throw new SparkException(
+ "File " + destFile + " exists and does not match contents of"
+ " " + url)
+ }
+ } else {
+ // Do nothing if the file contents are the same, i.e. this file
has been copied
+ // previously.
+ logInfo(sourceFile.getAbsolutePath + " has been previously copied
to "
--- End diff --
Same here; might be nice to use string formatters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
