Github user ryan-williams commented on a diff in the pull request:
https://github.com/apache/spark/pull/2848#discussion_r21386398
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -412,6 +403,48 @@ private[spark] object Utils extends Logging {
}
/**
+ * Download a file from @in to @tempFile, then move it to @destFile,
checking whether @destFile
+ * already exists, is equal to the downloaded file, and can be
overwritten.
+ */
+ private def maybeMoveFile(
+ url: String,
+ sourceFile: File,
+ destFile: File,
+ fileOverwrite: Boolean): Unit = {
+
+ var shouldCopy = true
--- End diff --
geez, seems like I had a bad merge at some point and dropped an important
code path in this function; e.g. the `Files.move` call is gone. will audit and
fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
