Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3582#discussion_r21352510
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfo.scala ---
    @@ -26,6 +29,17 @@ private[storage] class BlockInfo(val level: 
StorageLevel, val tellMaster: Boolea
       private def failed: Boolean = size == BlockInfo.BLOCK_FAILED
       private def initThread: Thread = BlockInfo.blockInfoInitThreads.get(this)
     
    +  val lock = new ReentrantLock()
    +  private val waitNCondition = lock.newCondition()
    --- End diff --
    
    These variables could use comments to explain what they're used for.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to