Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3582#issuecomment-65740233
Hi @suyanNone,
I took a brief look through this PR but I'm having a hard time
understanding how this code works. I could some time to look more closely, but
it would be very helpful if you could add some comments to explain what purpose
the `WaitType` class serves and what its methods do. For tricky
synchronization / thread-safety logic like this, it's better to err on the side
of more comments.
Also, something as complex as `WaitType` should have its own tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
