Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/3570#issuecomment-65883848
oh, a note for when you're reviewing - I didn't move the clear call, I just
added a second one; I saw no particular harm in leaving the old one there too,
just in case, but I can't see it doing all that much anymore - it should always
be a no-op now. I'd be happier removing it if, again, I could figure out a
good unit test to make sure all was functioning properly when I did so. But I
would be totally open to removing it in the interests of code cleanliness if
you want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
